-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get/import/url: handle existing output directory #2610
Conversation
Currently if you run ``` dvc get https://github.com/iterative/example-get-started model.pkl --out . ``` it will nuke your cwd. To fix that we need to properly handle existing directories, same as usual unix cli utilities do that.
@efiop @jorgeorpinel should we create a ticker/clarify the |
@shcheklein Will do, I didn't click the docs checkbox in the description for that reason :) |
@shcheklein The docs are written correctly already, it was a bug on our side. |
@efiop I'm not sure that it's clear from this |
@shcheklein I was more focused on |
@efiop is that no longer the case? I don't see that text changed in the PR. Thanks |
@jorgeorpinel The defaults are the same, so I didn't change that text. |
cmd ref: describe updated `--out` behavior in get/import/*-url Per iterative/dvc#2610
Currently if you run
it will nuke your cwd. To fix that we need to properly handle existing
directories, same as usual unix cli utilities do that.
Have you followed the guidelines in our
Contributing document?
Does your PR affect documented changes or does it add new functionality
that should be documented? If yes, have you created a PR for
dvc.org documenting it or at
least opened an issue for it? If so, please add a link to it.
iterative/dvc.org#699