Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

much grammar such fix #2883

Merged
merged 3 commits into from
Dec 3, 2019
Merged

much grammar such fix #2883

merged 3 commits into from
Dec 3, 2019

Conversation

casperdcl
Copy link
Contributor

Fix various minor grammatical errors and inconsistencies in the main README.

@casperdcl casperdcl added enhancement Enhances DVC c3-small-fix ui user interface / interaction discussion requires active participation to reach a conclusion labels Dec 3, 2019
@casperdcl casperdcl self-assigned this Dec 3, 2019
@shcheklein
Copy link
Member

thanks @casperdcl 🙏

README.rst Outdated

The easiest (but not perfect!) *analogy* to describe it: DVC is Git (or Git-lfs to be precise) + ``makefiles``
The easiest (but not perfect!) *analogy* to describe it: DVC is Git (or Git-LFS to be precise) & ``Makefile``s
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

erm. Is the Travis error due to this? As in

``Makefile``s # not allowed
``Makefile``. # allowed
``Makefile``, # allowed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just based on the highlighting I suppose so. Lame.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

triple neat 👌 👌 👌

thanks, @casperdcl !

Copy link
Member

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @casperdcl ! 🙏

@efiop efiop merged commit e63bc01 into iterative:master Dec 3, 2019
@casperdcl casperdcl deleted the readme-native branch December 3, 2019 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion requires active participation to reach a conclusion enhancement Enhances DVC ui user interface / interaction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants