Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import-url: add directories to examples #2907

Merged
merged 1 commit into from Dec 11, 2019
Merged

Conversation

efiop
Copy link
Member

@efiop efiop commented Dec 6, 2019

#2894

  • ❗ Have you followed the guidelines in the Contributing to DVC list?

  • πŸ“– Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.

  • ❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

@efiop
Copy link
Member Author

efiop commented Dec 6, 2019

For the record: windows test failing because of unrelated issues with chocolatey.

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Check this box if this PR does not require documentation updates...

Why is this checked? :P Perhaps I haven't noticed the PR on dvc.org? Otherwise, I also approve these changes.

@shcheklein
Copy link
Member

@jorgeorpinel bc ... or at least opened an issue about it in that repo :)

@efiop efiop merged commit 5cc92a9 into iterative:master Dec 11, 2019
@efiop efiop self-assigned this Dec 11, 2019
@efiop efiop added this to In progress in DVC Sprint 3 Dec 2019 - 17 Dec 2019 via automation Dec 11, 2019
@efiop efiop deleted the import_get branch December 11, 2019 01:24
@efiop efiop moved this from In progress to Reviewer approved in DVC Sprint 3 Dec 2019 - 17 Dec 2019 Dec 11, 2019
@efiop efiop moved this from Reviewer approved to Done in DVC Sprint 3 Dec 2019 - 17 Dec 2019 Dec 11, 2019
@jorgeorpinel
Copy link
Contributor

You conveniently omit

Please link below to your PR (or issue) in the dvc.org repo.

@shcheklein πŸ˜‹

OK, found it: iterative/dvc.org/issues/841

@shcheklein
Copy link
Member

You conveniently omit

@jorgeorpinel only bc it's referenced and is visible here already:

Screen Shot 2019-12-11 at 12 40 55 PM

@jorgeorpinel
Copy link
Contributor

That is a link from the issue back to this PR. I think we mean a link to the issue in this PR? (In the description of the PR in fact.) Would be much more visible I think. I mean, there's many of these automated thingies in PRs and I doubt people always pay attention to them. E.g.:

image

Just trying to understand the meaning of that sentence in the PULL_REQUEST template.

@jorgeorpinel
Copy link
Contributor

p.s. Obviously this is no longer relevant in this case but (and I was mostly messing around) but it's an interesting question for future reference actually.

@efiop
Copy link
Member Author

efiop commented Dec 11, 2019

@jorgeorpinel Will try to place it explicitly, thanks for the heads up. πŸ™‚

@shcheklein
Copy link
Member

Yeah, I think 95% of the job and value is to have the proper ticket created. I agree though that an explicit link in the PR/issue is better and improves readability. For me it was usually fine to see a connected issue in the PR - it serves both ways anyway.

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Dec 11, 2019

Thanks guys! Sorry to seem so strict, wasn't the intention originally 😬 obviously some times these small things slip and its totally fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants