Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: write a usage text for dir_helpers #2908

Merged
merged 5 commits into from
Dec 9, 2019
Merged

test: write a usage text for dir_helpers #2908

merged 5 commits into from
Dec 9, 2019

Conversation

Suor
Copy link
Contributor

@Suor Suor commented Dec 6, 2019

Closes #2893

@Suor Suor requested a review from a user December 6, 2019 17:56
@efiop
Copy link
Member

efiop commented Dec 6, 2019

For the record: windows test is failing due to unrelated issues with chocolatey.

ghost
ghost suggested changes Dec 8, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really neat, @Suor , thanks a lot for the description!

I added some comments fixing some typos and wording)

tests/dir_helpers.py Outdated Show resolved Hide resolved
tests/dir_helpers.py Outdated Show resolved Hide resolved
tests/dir_helpers.py Show resolved Hide resolved
tests/dir_helpers.py Show resolved Hide resolved
tests/dir_helpers.py Outdated Show resolved Hide resolved
@weekly-digest weekly-digest bot mentioned this pull request Dec 8, 2019
Closed
Suor and others added 3 commits December 9, 2019 11:24
@Suor
Update tests/dir_helpers.py
0cd6106 
Co-Authored-By: Mr. Outis <mroutis@protonmail.com>
@Suor
test: update dir_helpers usage
a59041a 
Co-Authored-By: Mr. Outis <mroutis@protonmail.com>
@Suor
test: update dir_helpers usage
1da133b 
Co-Authored-By: Mr. Outis <mroutis@protonmail.com>
@Suor Suor mentioned this pull request Dec 9, 2019
Merged
@Suor
Copy link
Contributor Author

Suor commented Dec 9, 2019

Are we good to go?

@efiop efiop requested review from a user and pared December 9, 2019 13:36
@efiop efiop merged commit 237704e into iterative:master Dec 9, 2019
@ghost
Copy link

ghost commented Dec 9, 2019

Good to go 👍

@Suor Suor added this to In progress in DVC Sprint 17 Dec 2019 - 31 Dec 2019 via automation Dec 15, 2019
@Suor Suor self-assigned this Dec 15, 2019
@Suor Suor removed this from In progress in DVC Sprint 17 Dec 2019 - 31 Dec 2019 Dec 15, 2019
@Suor Suor added this to In progress in DVC Sprint 3 Dec 2019 - 17 Dec 2019 via automation Dec 15, 2019
@Suor Suor moved this from In progress to Reviewer approved in DVC Sprint 3 Dec 2019 - 17 Dec 2019 Dec 15, 2019
@Suor Suor moved this from Reviewer approved to Done in DVC Sprint 3 Dec 2019 - 17 Dec 2019 Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pared pared pared approved these changes

Assignees

@Suor Suor

Labels
None yet
Projects
No open projects
DVC Sprint 3 Dec 2019 - 17 Dec 2019
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test: write a usage text for new pytest-style fixtures
3 participants
@Suor @efiop @pared