Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap: test: add build and deploy checks #3330

Merged
merged 2 commits into from Feb 14, 2020
Merged

snap: test: add build and deploy checks #3330

merged 2 commits into from Feb 14, 2020

Conversation

casperdcl
Copy link
Contributor

  • use snapd for build-time checks
  • use review-tools for pre-deploy checks

Enables pre-deployment checks
Enables enhanced build-time checks
@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #3330 into master will increase coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3330      +/-   ##
==========================================
+ Coverage   92.47%   92.83%   +0.36%     
==========================================
  Files         140      140              
  Lines        8473     8473              
==========================================
+ Hits         7835     7866      +31     
+ Misses        638      607      -31
Impacted Files Coverage Δ
dvc/analytics.py 96.05% <0%> (+1.31%) ⬆️
dvc/remote/ssh/connection.py 87% <0%> (+4.5%) ⬆️
dvc/system.py 87.71% <0%> (+9.64%) ⬆️
dvc/compat.py 72.22% <0%> (+55.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b737a0...3f992c5. Read the comment docs.

@casperdcl casperdcl self-assigned this Feb 14, 2020
@casperdcl casperdcl requested a review from efiop February 14, 2020 16:30
@casperdcl casperdcl added build Issues/features related to building dvc install packages. research testing Related to the tests and the testing infrastructure labels Feb 14, 2020
@casperdcl casperdcl marked this pull request as ready for review February 14, 2020 16:31
@efiop efiop merged commit 6932cf6 into master Feb 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the snap-checks branch February 14, 2020 17:05
@casperdcl casperdcl restored the snap-checks branch February 21, 2020 22:03
@casperdcl casperdcl deleted the snap-checks branch February 21, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues/features related to building dvc install packages. research testing Related to the tests and the testing infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants