Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update flake8 to latest version #4403

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Conversation

skshetry
Copy link
Member

There are some false positives in the older versions, particularly regarding type annotations that are blocking my other PR.

Also, there were some false negatives that seem to have been fixed, which has been adjusted.

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

@skshetry skshetry self-assigned this Aug 17, 2020
@skshetry skshetry added this to In progress in DVC 11 - 25 August 2020 via automation Aug 17, 2020
@skshetry skshetry moved this from In progress to Done in DVC 11 - 25 August 2020 Aug 17, 2020
@skshetry skshetry mentioned this pull request Aug 17, 2020
2 tasks
@skshetry
Copy link
Member Author

This is not good, CI takes >35 mins to run. Should investigate why that is the case.

@skshetry skshetry merged commit 1cfccef into iterative:master Aug 17, 2020
@skshetry skshetry deleted the update-flake8 branch August 17, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant