cleanup RepoTree #4405
Merged
cleanup RepoTree #4405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Rename `_get_tree_pairs` to `_get_tree_pair`. 2. Add comments, docstrings and type-annotations. 3. Rename variable: `_discovered_subrepos` to `_subrepos_trie`. 4. Merge some nested ifs.
skshetry
force-pushed
the
repo-tree-cleanups
branch
from
9391f5b
to
4f9b791
Compare
pared
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_get_tree_pairsto_get_tree_pair. (addresses RepoTree: add support for subrepo traversal #4381 (comment))_discovered_subreposto_subrepos_trie.❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
On top of #4403, will rebase after it's merged. See 9391f5b for review.EDIT: Rebased