status: no warnings for missing state #4470
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4383 (again)
After PR #4398 it occured, that
dvc status -c
output is bloated and informs about "missing" files twice (took from #4398 (comment)):The WARNING shouldn't shown for
dvc status -c
. However it should be shown for all other commands (fetch
,gc
, etc.). This PR implements such behavior.P.R.: I didn't come up with anything better than adding
log_missing=True
param intodvc.data_cloud.DataCloud.status
and passing it all the way downdvc.cache.local._make_status
. It's ugly. If there any better way please inform me about it.β I have followed the Contributing to DVC checklist.
π If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
issue in dvc.or repo already exist: iterative/dvc.org#1701
Thank you for the contribution - we'll try to review it as soon as possible. π