Show name of experiments in the queue #6382
Conversation
dvc/repo/experiments/__init__.py
Outdated
| if rev in self.stash_revs: | ||
| return self.stash_revs[rev].name |
There was a problem hiding this comment.
This stash check should be done last - experiments (including stashed experiments) should have lower priority than tags or branch names
There was a problem hiding this comment.
Reorder here would make the code a little corrupt. And shouldn't the stash ones be mutually exclusive with the commit ones? But I agreed that making commit ones ahead of stash ones is a logical/common choice, I also hesitated here before I wrote them down.
There was a problem hiding this comment.
It's unlikely that a git tag or branch would ever point to one of our stash commits, but it's technically a legal state - you can manually tag any git commit, and manually create a refs/heads/branch_name entry that points to any git commit.
This includes our stash commits, so we have to account for it.
|
|
fix #6050
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏