exp show: Preserve full branch and tag names. #8425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daavoo
commented
Oct 11, 2022
| name = repo.experiments.get_exact_name(rev) | ||
| name = name or repo.experiments.get_exact_name(rev) | ||
| if name: | ||
| name = name.rsplit("/")[-1] |
Contributor
Author
There was a problem hiding this comment.
I believe this was not really needed after the introduction of repo.experiments.get_exact_name(rev) but it was left here, causing the unnecessary truncation.
Contributor
Author
There was a problem hiding this comment.
There was no test case for it
daavoo
force-pushed
the
7933-exp-show-branch-name-containing-path-separator-not-returned-for-head
branch
from
bad3205 to
02e78aa
Compare
pmrowla
approved these changes
Oct 11, 2022
pmrowla
deleted the
7933-exp-show-branch-name-containing-path-separator-not-returned-for-head
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7933