output: use remote kwarg instead of odb #6600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
changed the title
efiop
commented
Sep 13, 2021
| @@ -849,7 +849,8 @@ def get_dir_cache(self, **kwargs): | |||
| try: | |||
| objects.check(self.odb, obj) | |||
| except FileNotFoundError: | |||
| remote = self.repo.cloud.get_remote_odb(self.remote) | |||
| if self.remote: | |||
There was a problem hiding this comment.
This is getting irritating, will need to look into getting rid of get_dir_cache soon. 😞
There was a problem hiding this comment.
Shouldn't -r <remote> be of higher priority?
There was a problem hiding this comment.
My second choice would be to skip the remotes not matching with -r <remote>.
There was a problem hiding this comment.
Though, for dir cache, I would not care that much. 🤷🏼
There was a problem hiding this comment.
remote: has higher prioirity than -r, as documented in https://github.com/iterative/dvc.org/pull/2761/files . Similar how dvc imported remotes are not overriden by dvc pull -r
dberenbaum
reviewed
Sep 13, 2021
Co-authored-by: Dave Berenbaum <dave@iterative.ai>
efiop
changed the title
for more information, see https://pre-commit.ci
|
ci failure is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6596