Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data/objects: reduce log levels in dvc-objects and dvc-data #7783

Merged
merged 1 commit into from
May 19, 2022

Conversation

skshetry
Copy link
Member

Also introduces a validate_status kwarg in data.transfer,
which is used in DVC to log for missing version info. Just leaving as is was making some tests flaky in DVC, so I had to engineer this hack. 🥲

We still have two warnings:

dvc/dvc/data/checkout.py

Lines 264 to 267 in 82dc67d

logger.warning(
"No file hash info found for '%s'. It won't be created.",
fs_path,
)

logger.warning(
"Client ID and secret configured do not match the "
"actual ones used\nto access the remote. Do you "
"use multiple GDrive remotes and forgot to\nset "
"`gdrive_user_credentials_file` for one or more of them?"
)

I have left them out, and was not able to figure out some way to avoid these.

Also introduces a `validate_status` kwarg in `data.transfer`,
which is used in dvc to log for missing version info.
@skshetry skshetry added refactoring Factoring and re-factoring skip-changelog Skips changelog A: object-storage Related to the object/content-addressable storage A: data-management Related to dvc add/checkout/commit/move/remove labels May 19, 2022
@skshetry skshetry requested a review from efiop May 19, 2022 12:32
@skshetry skshetry requested a review from a team as a code owner May 19, 2022 12:32
@skshetry skshetry self-assigned this May 19, 2022
@skshetry skshetry merged commit 455260b into iterative:main May 19, 2022
@skshetry skshetry deleted the logging-objects-data2 branch May 19, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: data-management Related to dvc add/checkout/commit/move/remove A: object-storage Related to the object/content-addressable storage refactoring Factoring and re-factoring skip-changelog Skips changelog
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants