Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hydra_sweeps referenced before assignment #8530

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Conversation

dberenbaum
Copy link
Contributor

Queuing without overrides is broken due to referencing hydra_sweeps before assignment. Feel free to suggest a different place for the added test.

Copy link
Contributor

@daavoo daavoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad in #8521 🙏

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 94.25% // Head: 94.32% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (4703136) compared to base (69f78d3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8530      +/-   ##
==========================================
+ Coverage   94.25%   94.32%   +0.06%     
==========================================
  Files         431      431              
  Lines       32825    32826       +1     
  Branches     4582     4582              
==========================================
+ Hits        30940    30962      +22     
+ Misses       1466     1445      -21     
  Partials      419      419              
Impacted Files Coverage Δ
tests/func/experiments/test_set_params.py 100.00% <ø> (ø)
dvc/repo/experiments/run.py 97.50% <100.00%> (+2.62%) ⬆️
dvc/repo/experiments/queue/celery.py 89.47% <0.00%> (+4.30%) ⬆️
tests/unit/repo/experiments/conftest.py 94.33% <0.00%> (+5.66%) ⬆️
tests/func/experiments/test_queue.py 100.00% <0.00%> (+12.90%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daavoo daavoo enabled auto-merge (rebase) November 4, 2022 14:52
@daavoo daavoo merged commit 240f0eb into main Nov 4, 2022
@daavoo daavoo deleted the fix-hydra-sweeps branch November 4, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants