Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dvc: introduce multithreaded import and RFC #90

Merged
merged 1 commit into from
Jun 7, 2017
Merged

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Jun 7, 2017

This allows us to download files in a few threads.
Also includes RFC, as we can now get rid of import-bulk.py.
Fixes #85.

Signed-off-by: Ruslan Kuprieiev kupruser@gmail.com

@efiop efiop requested a review from dmpetrov June 7, 2017 01:42
Copy link
Member

@dmpetrov dmpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
I'm going to run some test after merging

@@ -14,6 +14,9 @@
from dvc.system import System
from dvc.data_cloud import DataCloud

#FIXME add cmdline argument and config option for POOL_SIZE
POOL_SIZE = 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use 4 by default.

This allows us to download files in a few threads.
Also includes RFC, as we can now get rid of import-bulk.py.

v2: use POOL_SIZE=4

Signed-off-by: Ruslan Kuprieiev <kupruser@gmail.com>
@efiop
Copy link
Contributor Author

efiop commented Jun 7, 2017

Added POOL_SIZE=4 in v2, merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants