Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data: scalar: Accept numpy scalars. #254

Merged
merged 1 commit into from
May 24, 2022
Merged

data: scalar: Accept numpy scalars. #254

merged 1 commit into from
May 24, 2022

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented May 15, 2022

Closes #253

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2022

Codecov Report

Merging #254 (9da0b11) into main (9602d7f) will increase coverage by 0.09%.
The diff coverage is 94.73%.

❗ Current head 9da0b11 differs from pull request most recent head 6fb8dff. Consider uploading reports for the commit 6fb8dff to get more accurate results

@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
+ Coverage   90.27%   90.36%   +0.09%     
==========================================
  Files          20       21       +1     
  Lines         699      716      +17     
==========================================
+ Hits          631      647      +16     
- Misses         68       69       +1     
Impacted Files Coverage Δ
dvclive/data/utils.py 91.66% <91.66%> (ø)
dvclive/data/__init__.py 100.00% <100.00%> (ø)
dvclive/data/scalar.py 97.77% <100.00%> (+0.21%) ⬆️
dvclive/live.py 97.16% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9602d7f...6fb8dff. Read the comment docs.

@daavoo daavoo merged commit b9144a5 into main May 24, 2022
@daavoo daavoo deleted the numpy-scalars branch May 24, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

live: <class 'numpy.float32'> rejected; Keras breaks if lr included metric in callback
3 participants