change save_dvc_exp warning to info #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #632 +/- ##
==========================================
- Coverage 89.69% 89.47% -0.22%
==========================================
Files 43 44 +1
Lines 2988 2994 +6
Branches 250 250
==========================================
- Hits 2680 2679 -1
- Misses 269 276 +7
Partials 39 39
☔ View full report in Codecov by Sentry. |
daavoo
approved these changes
Jul 20, 2023
Closed
1 task
shcheklein
reviewed
Jul 20, 2023
| logger.warning( | ||
| "Ignoring `_save_dvc_exp` because `dvc exp run` is running" | ||
| ) | ||
| logger.info("Ignoring `_save_dvc_exp` because `dvc exp run` is running") |
There was a problem hiding this comment.
QQ, is it how it is actual called - _save_dvc_exp?
There was a problem hiding this comment.
I mean for users? Or is it an internal name?
There was a problem hiding this comment.
Good catch. We should not be using the internal name here.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://github.com/iterative/dvclive/pull/631/files#r1269153204