Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change save_dvc_exp warning to info #632

Merged
merged 3 commits into from
Jul 20, 2023
Merged

change save_dvc_exp warning to info #632

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
810e346
change save_dvc_exp warning to info
dberenbaum Jul 20, 2023
faa4bf0
Delete _dvclive_version.py
daavoo Jul 20, 2023
d28f98f
Merge branch 'main' into exp-save-warning
dberenbaum Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/dvclive/live.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
formatter = logging.Formatter("%(levelname)s:%(name)s:%(message)s")
handler.setFormatter(formatter)
logger.addHandler(handler)
logger.setLevel(os.getenv(env.DVCLIVE_LOGLEVEL, "INFO").upper())

ParamLike = Union[int, float, str, bool, List["ParamLike"], Dict[str, "ParamLike"]]

Expand Down Expand Up @@ -133,9 +132,7 @@ def _init_dvc(self):
self._exp_name = os.getenv(env.DVC_EXP_NAME, "")
self._inside_dvc_exp = True
if self._save_dvc_exp:
logger.warning(
"Ignoring `_save_dvc_exp` because `dvc exp run` is running"
)
logger.info("Ignoring `_save_dvc_exp` because `dvc exp run` is running")
Copy link
Member

@shcheklein shcheklein Jul 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QQ, is it how it is actual called - _save_dvc_exp?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean for users? Or is it an internal name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. We should not be using the internal name here.

self._save_dvc_exp = False

self._dvc_repo = get_dvc_repo()
Expand Down