studio: Extract post_to_studio and decoulple from make_report
#705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daavoo
force-pushed
the
704-decouple-studio-updates-from-make_report
branch
from
90c8947
to
3a6478c
Compare
Merged
daavoo
added a commit
that referenced
this pull request
Sep 20, 2023
* live: Set new defaults `report=None` and `save_dvc_exp=True`. * frameworks: Drop model_file. * update examples * Write to root dvc.yaml (#687) * add dvcyaml to root * clean up dvcyaml implementation * fix existing tests * add new tests * add unit tests for updating dvcyaml * use posix paths * don't resolve symlinks * drop entire dvclive dir on cleanup * fix studio tests * revert cleanup changes * unify rel_path util func * cleanup test * refactor tests * add test for multiple dvclive instances * put dvc_file logic into _init_dvc_file --------- Co-authored-by: daavoo <daviddelaiglesiacastro@gmail.com> * report: Drop "auto" logic. Fallback to `None` when conditions are not met for other types. * studio: Extract `post_to_studio` and decoulple from `make_report` (#705) * refactor(tests): Split `test_main` into separate files. Rename test_frameworks to frameworks. * fix matplotlib warning * Studio dvcyaml (#709) * drop dvc.yaml prefix from studio plots * refactor * drop .dvc files * dvc version bump * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Bump dvc and dvc-render --------- Co-authored-by: dberenbaum <dave@iterative.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
skshetry
pushed a commit
that referenced
this pull request
Sep 21, 2023
* live: Set new defaults `report=None` and `save_dvc_exp=True`. * frameworks: Drop model_file. * update examples * Write to root dvc.yaml (#687) * add dvcyaml to root * clean up dvcyaml implementation * fix existing tests * add new tests * add unit tests for updating dvcyaml * use posix paths * don't resolve symlinks * drop entire dvclive dir on cleanup * fix studio tests * revert cleanup changes * unify rel_path util func * cleanup test * refactor tests * add test for multiple dvclive instances * put dvc_file logic into _init_dvc_file --------- Co-authored-by: daavoo <daviddelaiglesiacastro@gmail.com> * report: Drop "auto" logic. Fallback to `None` when conditions are not met for other types. * studio: Extract `post_to_studio` and decoulple from `make_report` (#705) * refactor(tests): Split `test_main` into separate files. Rename test_frameworks to frameworks. * fix matplotlib warning * drop dvc.yaml prefix from studio plots * refactor * drop .dvc files * track dvcyaml file * Studio dvcyaml (#709) * drop dvc.yaml prefix from studio plots * refactor * drop .dvc files * dvc version bump * drop unneeded relpath call * drop extra make_report call --------- Co-authored-by: daavoo <daviddelaiglesiacastro@gmail.com>
daavoo
added a commit
that referenced
this pull request
Sep 21, 2023
* live: Set new defaults `report=None` and `save_dvc_exp=True`. * frameworks: Drop model_file. * update examples * Write to root dvc.yaml (#687) * add dvcyaml to root * clean up dvcyaml implementation * fix existing tests * add new tests * add unit tests for updating dvcyaml * use posix paths * don't resolve symlinks * drop entire dvclive dir on cleanup * fix studio tests * revert cleanup changes * unify rel_path util func * cleanup test * refactor tests * add test for multiple dvclive instances * put dvc_file logic into _init_dvc_file --------- Co-authored-by: daavoo <daviddelaiglesiacastro@gmail.com> * report: Drop "auto" logic. Fallback to `None` when conditions are not met for other types. * studio: Extract `post_to_studio` and decoulple from `make_report` (#705) * refactor(tests): Split `test_main` into separate files. Rename test_frameworks to frameworks. * fix matplotlib warning * drop dvc.yaml prefix from studio plots * refactor * drop .dvc files * track dvcyaml file * Studio dvcyaml (#709) * drop dvc.yaml prefix from studio plots * refactor * drop .dvc files * dvc version bump * drop unneeded relpath call * drop extra make_report call * test for git add dvc.yaml in exp run --------- Co-authored-by: daavoo <daviddelaiglesiacastro@gmail.com>
dberenbaum
added a commit
that referenced
this pull request
Feb 15, 2024
* post to studio even without git/dvc repo * tests for no-git scenario * studio: make no-repo paths relative to cwd * make ruff happy * don't require exp name * don't require baseline rev * refactor studio path formatting * live: Set new defaults `report=None` and `save_dvc_exp=True`. * frameworks: Drop model_file. * update examples * Write to root dvc.yaml (#687) * add dvcyaml to root * clean up dvcyaml implementation * fix existing tests * add new tests * add unit tests for updating dvcyaml * use posix paths * don't resolve symlinks * drop entire dvclive dir on cleanup * fix studio tests * revert cleanup changes * unify rel_path util func * cleanup test * refactor tests * add test for multiple dvclive instances * put dvc_file logic into _init_dvc_file --------- Co-authored-by: daavoo <daviddelaiglesiacastro@gmail.com> * report: Drop "auto" logic. Fallback to `None` when conditions are not met for other types. * studio: Extract `post_to_studio` and decoulple from `make_report` (#705) * refactor(tests): Split `test_main` into separate files. Rename test_frameworks to frameworks. * fix matplotlib warning * fix studio tests * fix windows studio paths * fix windows studio paths for plots * skip fabric tests if not installed * drop dvc repo * drop dvcignore * drop unrelated test_fabric.py file * fix windows paths * fix windows paths * adapt plot paths even if no dvc repo * default baseline rev to all zeros * consolidate repro tests * set null sha as variable * add type hints to studio * limit windows path handling to studio * fix typing errors in studio module * fix mypy in live module * drop checking for dvc_file --------- Co-authored-by: daavoo <daviddelaiglesiacastro@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.