track dvcyaml file #710
Merged
track dvcyaml file #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add dvcyaml to root * clean up dvcyaml implementation * fix existing tests * add new tests * add unit tests for updating dvcyaml * use posix paths * don't resolve symlinks * drop entire dvclive dir on cleanup * fix studio tests * revert cleanup changes * unify rel_path util func * cleanup test * refactor tests * add test for multiple dvclive instances * put dvc_file logic into _init_dvc_file --------- Co-authored-by: daavoo <daviddelaiglesiacastro@gmail.com>
Fallback to `None` when conditions are not met for other types.
Rename test_frameworks to frameworks.
* drop dvc.yaml prefix from studio plots * refactor * drop .dvc files * dvc version bump
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
daavoo
reviewed
Sep 15, 2023
daavoo
reviewed
Sep 20, 2023
| @@ -548,6 +548,10 @@ def end(self): | |||
| catch_and_warn(DvcException, logger)(ensure_dir_is_tracked)( | |||
| self.dir, self._dvc_repo | |||
| ) | |||
| if self._dvcyaml: | |||
| catch_and_warn(DvcException, logger)(self._dvc_repo.scm.add)( | |||
There was a problem hiding this comment.
Do you mean the warnings? Not sure what scenario would actually trigger an exception here 🤔 .
There was a problem hiding this comment.
I meant the scm.add, it seems that we only test the include_untracked change
There was a problem hiding this comment.
Good catch. Added it to test_untracked_dvclive_files_inside_dvc_exp_run_are_added.
daavoo
approved these changes
Sep 20, 2023
|
Not sure why the tests are failing. Some error relating to the version. |
|
@skshetry WDYT? Should the failure block merging? |
|
@dberenbaum, let me try to rerun, it is probably fixed in setuptools_scm. If not, we can merge it and pin it separately. :) |
skshetry
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
dvc.yamlwill be written to the root, this PR ensures it is git-tracked.