-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pylint, pydantic, remove "artifacts.yaml" logic #401
Conversation
Codecov ReportPatch coverage is
馃摙 Thoughts on this report? Let us know!. |
cc @amritghimire about changes required in BE ^ |
@pmrowla, I assume this is what you meant to make it compatible with py-template. There are few things still that should be fixed - like remove top-level silence statements here https://github.com/iterative/gto/blob/bumping-versions/gto/config.py#L1, but overall it should be ready for py-template I hope! |
closes #400 |
Since studio depends for now on MLEM and MLEM depends on the first Pydantic, will those co-exist fine together or does it means we need to upgrade / drop MLEM dependency? |
afddc5e
to
0d1a74d
Compare
0d914b1
to
6936f5e
Compare
Split out from #401 to make it easier to review. Some test changes and behaviour changes have been dropped.
Split out from #401 to make it easier to review. Only cosmetic changes have been made and some linters errors are suppressed.
6936f5e
to
59fd780
Compare
59fd780
to
71687f5
Compare
We discussed this in today's team meeting and decided not to merge this PR due to the breakages involved. We don't want to risk merging this for now. Most of the pylint/mypy changes has been cherry-picked into the main branch, and CI is now running from Python 3.8 - 3.11 versions now. I have created #413 that supports both Pydantic v1 and v2, so there's no immediate need to migrate to use pydantic v2 APIs too. (For future reference, afddc5e is the last commit before it was rebased). |
71687f5
to
f2e7850
Compare
f2e7850
to
f8e6cec
Compare
馃憖
This will require Studio BE update - we need to remove old logic that works with
artifacts.yaml
- that will make Studio MR backend codebase more easy to work with! To clarify, before we already removed "write" access to oldartifacts.yaml
, but kept "read" access. Now we remove "read" access as well. (Please notice, that will lead to some users losing info about model versions that are 3+ months old, but I hope that's ok).So once this merged, consider bumping major or minor version, but not the patch.