Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update GTO to be in line with iterative/py-template standards #400

Closed
pmrowla opened this issue Sep 5, 2023 · 4 comments
Closed

update GTO to be in line with iterative/py-template standards #400

pmrowla opened this issue Sep 5, 2023 · 4 comments
Assignees
Labels
housekeeping CI, tests, maintenance and dev productivity p2-medium Medium priority

Comments

@pmrowla
Copy link
Contributor

pmrowla commented Sep 5, 2023

          DVC officially, supports Python 3.8 through 3.11 but GTO CI is only run against 3.8 through 3.10 (GTO CI fails if you enable 3.11). As far as I can tell, the 3.11 failure is because GTO requires outdated pylint and mypy installations that are just broken on 3.11. The actual test suite passes in 3.11.

IMO there is a lot more work that needs to be done in GTO to bring it in line with current DVC and iterative/py-template standards, but for the time being I am leaving all of that alone (GTO codebase fails pylint/mypy checks after updating and enabling the py-template or DVC configurations for those tools)

Making GTO pass current mypy/pylint may also require updating other deps (and updating pydantic may require migrating from pydantic v1 to v2 - #375)

Originally posted by @pmrowla in #378 (comment)

@shcheklein
Copy link
Member

I think we've updated pydantic, also it runs on 3.11. What else do we usually need to get it to py-template?

@shcheklein shcheklein added housekeeping CI, tests, maintenance and dev productivity p2-medium Medium priority labels Sep 23, 2023
@pmrowla
Copy link
Contributor Author

pmrowla commented Sep 25, 2023

This can be closed, issues were all addressed in:

@shcheklein
Copy link
Member

Thanks, Peter. Do we want / need to upgrade it to py template?

@pmrowla
Copy link
Contributor Author

pmrowla commented Sep 25, 2023

There isn't really a straightforward way to retroactively apply a cookiecutter/cruft template on top of an existing git repo, so any major changes that are made in py-template in the future would need to be done manually in GTO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping CI, tests, maintenance and dev productivity p2-medium Medium priority
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants