Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

Allow access to secrets for external contributors #318

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

aguschin
Copy link
Contributor

Using the changes from iterative/cml#574

@aguschin aguschin requested a review from a team as a code owner June 28, 2022 15:33
@aguschin aguschin self-assigned this Jun 28, 2022
@aguschin aguschin added 🏡 housekeeping Fighting technical debt and improving dev process credentials Authentication-related stuff labels Jun 28, 2022
@aguschin aguschin requested a review from 0x2b3bfa0 June 28, 2022 15:36
@aguschin
Copy link
Contributor Author

@0x2b3bfa0 could you please TAL?

@0x2b3bfa0
Copy link
Member

Note that the external environment should be configured to require @iterative/mlem as reviewer to approve every run.

@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Jun 28, 2022

E.g. visit https://github.com/iterative/mlem/settings/environments/new and create a new environment named external with the following settings:


Captura de pantalla 2022-06-28 a las 17 43 04

Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although still needs an administrator to configure the external environment before merging.

@aguschin
Copy link
Contributor Author

Thanks @0x2b3bfa0! I've created an environment. Do I need to copy secrets from Repository secrets to Environment secrets now? Or it will work with all secrets listed in Repository secrets only?

@aguschin
Copy link
Contributor Author

As per this page I found repository secrets should be available in the environment. Merging :)
https://dev.to/n3wt0n/how-secrets-work-in-github-and-how-to-manage-them-p4o

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
credentials Authentication-related stuff 🏡 housekeeping Fighting technical debt and improving dev process
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants