-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes/cleanup to manifest and config #107
Conversation
+1 Google Chrome team also updated |
@@ -1,6 +1,6 @@ | |||
'use strict'; | |||
|
|||
function _typeof(obj) { return obj && typeof Symbol !== "undefined" && obj.constructor === Symbol ? "symbol" : typeof obj; } | |||
var _typeof = typeof Symbol === "function" && typeof Symbol.iterator === "symbol" ? function (obj) { return typeof obj; } : function (obj) { return obj && typeof Symbol === "function" && obj.constructor === Symbol ? "symbol" : typeof obj; }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happened here? Part of a Babel update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea; babel.
Awesome, loving these commits mate :) Just gotta sort out a few questions then I'm good to merge |
Also @phbernard You should cross reference this with your code :) |
Fixes/cleanup to manifest and config
path
member in config. This is because, in helpers.js,_.map()
creates a new array and does not mutate the passed in array (among other reasons).density
member in manifest.json has been changed to a number. While technically having the value as a string should work, the specification alludes to it being a number type.<link>
element for the coast icon.