Fixes/cleanup to manifest and config #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 Google Chrome team also updated |
| @@ -1,6 +1,6 @@ | |||
| 'use strict'; | |||
|
|
|||
| function _typeof(obj) { return obj && typeof Symbol !== "undefined" && obj.constructor === Symbol ? "symbol" : typeof obj; } | |||
| var _typeof = typeof Symbol === "function" && typeof Symbol.iterator === "symbol" ? function (obj) { return typeof obj; } : function (obj) { return obj && typeof Symbol === "function" && obj.constructor === Symbol ? "symbol" : typeof obj; }; | |||
There was a problem hiding this comment.
What happened here? Part of a Babel update?
|
Awesome, loving these commits mate :) Just gotta sort out a few questions then I'm good to merge |
|
Also @phbernard You should cross reference this with your code :) |
Closed
haydenbleasel
pushed a commit
that referenced
this pull request
Jan 20, 2016
Fixes/cleanup to manifest and config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pathmember in config. This is because, in helpers.js,_.map()creates a new array and does not mutate the passed in array (among other reasons).densitymember in manifest.json has been changed to a number. While technically having the value as a string should work, the specification alludes to it being a number type.<link>element for the coast icon.