Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Subjective) enhancements to how MMods work internally #56

Open
wants to merge 1 commit into
base: beta
Choose a base branch
from

Conversation

tertu-m
Copy link
Contributor

@tertu-m tertu-m commented Aug 2, 2022

Code for calculating the read BPM for MMods moved from Player to Steps and Trail
Lua functions for getting the read BPM for a Steps and Trail and the current read BPM of a PlayerState
The possibility of MMods being calculated for each chart rather than each song (not currently enabled)

Code for calculating the read BPM for MMods moved from Player to Steps and Trail
Lua functions for getting the read BPM for a Steps and Trail and the current read BPM of a PlayerState
The possibility of MMods being calculated for each chart rather than each song (not currently enabled)
@natano
Copy link
Contributor

natano commented Oct 28, 2022

@tertu-m Do you have a use case for exposing the new functions to Lua?

@tertu-m
Copy link
Contributor Author

tertu-m commented Nov 1, 2022

If themes use GetMModReadBpm, they can know exactly what read BPM the MMod code will use to calculate the effective scroll rate. This means that themes don't have to duplicate the MMod code if they want to display the effective MMod speeds, and means if the way that ITGmania were to calculate MMods changed, themes would still be able to display accurate MMod values (switching from per-Song to per-Steps read BPM calculation being one example).

@tertu-m
Copy link
Contributor Author

tertu-m commented Dec 12, 2022

Sorry, I didn't clarify that was a use case. I've worked a StepMania theme that does that, and in theory Simply Love could use these calls to implement an MMod range on the options select screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants