Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon: Add compare and side-panel icons #596

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

michael-iden
Copy link
Contributor

This change: (check at least one)

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?
  • Component status page up to date?

What does this change address?
Adds two icons

  • Compare
  • Side panel

How does this change work?
Include new icons

Additional context

@michael-iden michael-iden requested a review from a team as a code owner August 30, 2023 17:58
@michael-iden michael-iden requested review from eslawski, SMQuazi and mtorres3 and removed request for a team August 30, 2023 17:58
@changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2023

🦋 Changeset detected

Latest commit: 4e6c422

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ithaka/pharos Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023

size-limit report 📦

Path Size
packages/pharos/lib/index.js 49.76 KB (0%)

@jialin-he jialin-he merged commit 8c223fa into develop Aug 31, 2023
8 checks passed
@jialin-he jialin-he deleted the feat/compare-side-panel-icons branch August 31, 2023 13:02
@github-actions github-actions bot mentioned this pull request Aug 31, 2023
daneah added a commit that referenced this pull request Sep 15, 2023
* develop:
  chore: version packages (#611)
  Popover: Border radius styling enforcement (#610)
  Sheet: Component Contribution (#603)
  docs: add @sirrah-tam as a contributor (#607)
  Tokens: improve glacier-blue-40 AAA color contrast (#606)
  chore: bump dependencies and update resolutions (#605)
  Dropdown: add line rules for light variants (#599)
  chore: version packages (#601)
  feat(icon): add compare and side-panel icons (#596)
  chore(sidenav): fix flaky test (#600)
  chore: version packages (#595)
  Popover: new element contribution (#588)
sirrah-tam pushed a commit to sirrah-tam/pharos that referenced this pull request Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants