Update sidenav-links marked as external to open in a new tab #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
External links now will open in a new tab matching the documentation, as well as having rel="noopener" added to the link. If a target is manually specified it will be used instead of the "_blank" set by it being external.
brentswisher
requested review from
daneah,
mtorres3 and
satya-achanta-venkata
and removed request for
a team
🦋 Changeset detectedLatest commit: d6b5bf4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
daneah
approved these changes
Nov 3, 2023
satya-achanta-venkata
approved these changes
Nov 3, 2023
mtorres3
approved these changes
Nov 3, 2023
sirrah-tam
added a commit
to sirrah-tam/pharos
that referenced
this pull request
Nov 15, 2023
commit 1f29064 Merge: 5dc8c3e 1875aaa Author: Mat Harris <mat.harris@ithaka.org> Date: Wed Nov 15 12:42:11 2023 -0500 Merge branch 'develop' of github.com:ithaka/pharos into develop commit 1875aaa Author: Brent Swisher <brent@brentswisher.com> Date: Mon Nov 6 16:11:11 2023 -0500 fix(sidenav-link): external link opens in new tab (ithaka#645) External links now will open in a new tab matching the documentation, as well as having rel="noopener" added to the link. If a target is manually specified it will be used instead of the "_blank" set by it being external.
sirrah-tam
pushed a commit
to sirrah-tam/pharos
that referenced
this pull request
Dec 1, 2023
External links now will open in a new tab matching the documentation, as well as having rel="noopener" added to the link. If a target is manually specified it will be used instead of the "_blank" set by it being external.
daneah
added a commit
that referenced
this pull request
Dec 19, 2023
* develop: A11y revamp: Pharos buttons (non-breaking change) (#628) Radio, Checkbox: Fix group label (#652) Add elevation tokens and documentation (#643) fix(sidenav-link): external link opens in new tab (#645) Upgrade to TypeScript 5 (#644) feat(cli): add newly created components created using pharos-cli to initComponents files (#630) chore: version packages (#640) Coach Mark: Fix react component positioning (#638) Coach Mark: Documentation fixes (#639) chore(deps): bump @babel/traverse from 7.20.0 to 7.23.2 (#637) chore: version packages (#636) Icon: Add Panorama icon (#631) chore: version packages (#629) Loading spinner: add small and on background variant (#627) chore: version packages (#626) Sheet: allow expansion with attribute (#625) fix(button): remove fill on subtle disabled button on background (#618) chore(deps-dev): bump postcss from 8.4.25 to 8.4.31 (#624) chore: version packages (#623) Sheet: Add more close options and transition timing function (#620)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External sidenav links now will open in a new tab matching the documentation, as well as having rel="noopener" added to the link.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
Closes #538
How does this change work?
If a
PharosSidenavLinkis created with the external option, the link will be rendered with target="_blank" and rel="noopener". If for some reason someone manually specified a target with external it will still respect the target that was set.Additional context