Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in MaxDistanceSplitter #306

Open
mattrjackson opened this issue Mar 23, 2020 · 1 comment
Open

Bug in MaxDistanceSplitter #306

mattrjackson opened this issue Mar 23, 2020 · 1 comment
Assignees
Labels

Comments

@mattrjackson
Copy link

Hi, I just wanted to report a small issue that happens only in the rarest of cases. In my case, I ran across a road that was exactly 5 km (the max edge length), and the splitter created 3 segments, with 1 segment of length zero .

In line 67:
if (data.Distance < _maxDistance)

should, I believe, be:

if (data.Distance <= _maxDistance)

@xivk xivk self-assigned this Mar 24, 2020
@xivk xivk added the bug label Mar 24, 2020
juliusfriedman added a commit to juliusfriedman/routing that referenced this issue Apr 2, 2020
@juliusfriedman
Copy link

Just noting that I was unable to make a contracted db after making this change (on a planet sized pbf filtered for rail data), the exception I received was

Edge detected that's too long in ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants