Fixes for ToGo functionality: metadata dump() and togo get_tivo_file() #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ffmpeg stalls when run in the background changed two lines in transcode.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the dump() method, the calls to str.encode() resulted in a string representation of the bytes of the string intended to be rendered into the text file; the encode() call is unnecessary as UTF-8 is the default encoding in Python 3.
In the get_tivo_file() method, name is assigned a value based on itself prior to it being instantiated; the value should have been based on name_list.
Also, step 2A of the installation instructions did not work. Adding "--spec" before the "git+" URL and the name of the package after a space after the URL did work.