Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design Card components (m1) #3

Open
5 tasks done
RudeSoul opened this issue Jun 1, 2021 · 0 comments · May be fixed by #11
Open
5 tasks done

Design Card components (m1) #3

RudeSoul opened this issue Jun 1, 2021 · 0 comments · May be fixed by #11
Assignees
@devnabin @reganspk @bijudhungel11
Labels
design Design request new component For creating new component
Projects
ITSNP Blog
Milestone
Complete Card Com...

Comments

@RudeSoul
Copy link
Collaborator

RudeSoul commented Jun 1, 2021 •
edited by bijudhungel11

Requirements

  1. The cards need to be pixel perfect to the Figma design,
  2. Card must be responsive for all screen
  3. props should be maintained if needed

TODO : cards
@RudeSoul RudeSoul added design Design request new component For creating new component labels Jun 1, 2021
@RudeSoul RudeSoul added this to To do in ITSNP Blog via automation Jun 1, 2021
@unravelbibek unravelbibek changed the title Design Card components Design Card components (m1) Jun 2, 2021
@SurrealSerenade SurrealSerenade moved this from To do to In progress in ITSNP Blog Jun 10, 2021
@bijudhungel11 bijudhungel11 linked a pull request Jun 10, 2021 that will close this issue
ITSNP-3: Design Card components #11
Open
bijudhungel11 added a commit that referenced this issue Jun 11, 2021
@bijudhungel11
Designed Card Component post trending card component #3
1c0864f 
- changed font-weight-family mixin to font
- try to make reusable component
- removed flex-item-center
@bijudhungel11 bijudhungel11 moved this from In progress to Review in progress in ITSNP Blog Jun 13, 2021
bijudhungel11 added a commit that referenced this issue Jun 19, 2021
@bijudhungel11
Designed card componenet #3 Refactor
71c0989 
- Removed constants folder to import all images
- directly importing from the resources folder to the component
bijudhungel11 added a commit that referenced this issue Jun 21, 2021
@bijudhungel11
Resolved issue in desinged card compenent #3
a7bcd35 
- changed caption naming convention for alternative attribut in image tag with imageTitle props
- tried to use Avatar component which was call from  profileComp branch made by ace4port
- moved the circles folder to joinMadhyam component folder where it belongs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devnabin devnabin

@reganspk reganspk

@bijudhungel11 bijudhungel11

Labels
design Design request new component For creating new component
Projects
ITSNP Blog
Review in progress
Milestone
Complete Card Component Design (SCSS)
Development

Successfully merging a pull request may close this issue.

ITSNP-3: Design Card components itsnporg/blog-itsnp-frontend
5 participants
@RudeSoul @devnabin @reganspk @bijudhungel11 @unravelbibek