ITSNP-3: Design Card components #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bijudhungel11
commented
Jun 7, 2021
bijudhungel11
commented
- Designed posts trending component card
- created resources folder under src which contains images
- created constants folder for importing all images from resources folder
- made mixin for font and display item in flex
- shame: design is not responsive
- Designed posts trending component card - created resources folder under src which contains images - created constants folder for importing all images from resources folder - made mixin for font and display item in flex - shame: design is not responsive
|
@bijudhungel11 Please link the issue related to this pull request (PR). Also, name the PR as ITSNP-03: Design Card Components. Thank you. |
|
I think this is the first thing you need to fix,
|
SurrealSerenade
requested changes
Jun 9, 2021
RudeSoul
requested changes
Jun 9, 2021
- removed font family link tag from index.html - provided data through props in posts Trending card component - added imported react from library to the top of component
- used naming convnetion to capitalize the allImage to AllImage - created icons folder to keep the all svg icons as component - used BEM mixins in post trednindg card componenet scss file - tried to created reusable mixin for fonts
SurrealSerenade
changed the title
SurrealSerenade
changed the title
5 tasks
SurrealSerenade
assigned bijudhungel11 and SurrealSerenade and unassigned bijudhungel11
SurrealSerenade
added
design
- changed font-weight-family mixin to font - try to make reusable component - removed flex-item-center
- have completed BlogPostCard - have completed SmalCardBlogPost Card and done it's style as welll - have comleted MediumCardBlogPost Card - imported all images from resources folder - shame: Overall Design is not completed and any other mixins has not been made - shame: haven't work deeply need to fix lot's of stuff - shame: haven't exported image directly from Image.js as we are guided to export it directly from Image.js
- changed image imoprt to svg component import - tried to provide the props for all dyanamic data - changed some scss to make pixel perfect - shame: still some scss is not refactored
- resolve Images
- Removed constants folder to import all images - directly importing from the resources folder to the component
ace4port
requested changes
Jun 20, 2021
- changed caption naming convention for alternative attribut in image tag with imageTitle props - tried to use Avatar component which was call from profileComp branch made by ace4port - moved the circles folder to joinMadhyam component folder where it belongs
bijudhungel11
assigned RudeSoul, SurrealSerenade and ace4port and unassigned reganspk and bijudhungel11
src/components/BlogPostCard/index.js
Outdated
| imageTitle, | ||
| authorImg, | ||
| date = "May 17", | ||
| authorName = "XettriAl.", |
There was a problem hiding this comment.
Does not make much sense to have default values for props date and authorName as "May 17" and "XettriAl.".
| import SmallPink from "./Circles/SmallPink"; | ||
| import Purple from "./Circles/Purple"; | ||
| const JoinMadhyamCard = ({ | ||
| topic = "Join Mnadhyam!", |
There was a problem hiding this comment.
Please correct this spelling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.