Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Fetch Blocks and Txs Bug (Not found) in postBerlin Blocks and Transactions #69

Merged
merged 1 commit into from
May 2, 2022

Conversation

Gustbel
Copy link
Contributor

@Gustbel Gustbel commented Apr 29, 2022

This PR solves the "Fetch Blocks and Txs Berlin/London version" issue. (Blocks and Tx not found).

The bug arises because the program is using an old version of github.com/ethereum/go-ethereum (v1.9.25, Muir Glacier compatible), so the .Hash() function call (in both Blocks and Tx ) returns an incorrect Hash that does not correspond to a correct Berlin/London Hash.
Because in parts of the code, the Geth functions BlockByHash() and TransactionByHash() are called, the Blocks and Txs are never found since the hash was miscalculated with respect to newer versions.

This PR only updates the Geth Mod to the latest stable version (v1.10.17) and adds other necessary new ones that the new version of Geth needs.

Another small bug has been detected but I prefer to present another PR for it, since it may be a little more controversial than this one that I consider necessary.

Copy link
Owner

@itzmeanjan itzmeanjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@itzmeanjan
Copy link
Owner

This PR solves the "Fetch Blocks and Txs Berlin/London version" issue. (Blocks and Tx not found).

The bug arises because the program is using an old version of github.com/ethereum/go-ethereum (v1.9.25, Muir Glacier compatible), so the .Hash() function call (in both Blocks and Tx ) returns an incorrect Hash that does not correspond to a correct Berlin/London Hash. Because in parts of the code, the Geth functions BlockByHash() and TransactionByHash() are called, the Blocks and Txs are never found since the hash was miscalculated with respect to newer versions.

This PR only updates the Geth Mod to the latest stable version (v1.10.17) and adds other necessary new ones that the new version of Geth needs.

Another small bug has been detected but I prefer to present another PR for it, since it may be a little more controversial than this one that I consider necessary.

Thanks @Gustbel 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants