Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update flask_pusher.py #12

Merged
merged 2 commits into from
May 19, 2016
Merged

Update flask_pusher.py #12

merged 2 commits into from
May 19, 2016

Conversation

ScriptProdigy
Copy link
Contributor

Added SSL config option.

@ScriptProdigy
Update flask_pusher.py
4208154 
Added SSL config option.
@coveralls
Copy link

coveralls commented May 18, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-5.8%) to 92.903% when pulling 4208154 on ScriptProdigy:patch-1 into 453a17c on iurisilvio:master.

@iurisilvio
Copy link
Owner

Thanks for your contribution! Definitelly it's a good thing to add, but breaks pusher<1.0.

You must check __v1__ variable and add the ssl configuration to pusher_kwargs.

@ScriptProdigy
Copy link
Contributor Author

Ah, good catch, pushed another patch here

@coveralls
Copy link

coveralls commented May 19, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 98.718% when pulling e453801 on ScriptProdigy:patch-1 into 453a17c on iurisilvio:master.

@iurisilvio iurisilvio merged commit 1cc6a96 into iurisilvio:master May 19, 2016
@iurisilvio
Copy link
Owner

Great! Thanks! 🍰

@ScriptProdigy
Copy link
Contributor Author

Mind doing a release? I use this with pip, doesn't pull the latest commits, only releases I believe.

@iurisilvio
Copy link
Owner

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ScriptProdigy @coveralls @iurisilvio