Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Global playback speed, volume settings update based on per-video changes instead of remaining as-is #3105

Open
chocmake opened this issue May 23, 2022 · 4 comments
Labels
bug Something isn't working module:account Preferences & account management module:player Impacts the video player of Invidious

Comments

@chocmake
Copy link

chocmake commented May 23, 2022

Describe the bug
In the global Invidious preferences if one sets the playback speed ('Default speed') to say 1.5x and the player volume to say 50% it persists until the user adjusts either the speed/volume of any single video, whereupon the global settings become updated to the value of that single video.

IIRC this didn't used to be the behavior as of a few weeks ago (if the bug label is incorrect, apologies). Normally I have the global playback speed as 1.5x and only want 1x in rare instances. Similarly I have the global volume between 25-50% since some videos are too loud and some too soft and it provides a consistent baseline for headroom so I'm not caught by surprise volume shifts (also one can't tell what the prior volume is otherwise without playing a video first).

Since both settings now change globally after adjusting just one video's settings it means there isn't the consistent, expected speed and volume I'd manually set in the global settings.

Steps to Reproduce

  1. Go to an instance and change the Default speed and Player volume preferences to something non-default (eg: 1.5 and 50%, respectively).
  2. Open any video and observe the global settings respected.
  3. Now adjust the playback speed and volume for just that single video.
  4. Open a different video and observe the settings adjusted of the prior video persist instead of respecting the previously customized global values in the preferences.

Additional context
Tested on both invidious.snopyta.org and invidious.kavin.rocks instances.

@chocmake chocmake added the bug Something isn't working label May 23, 2022
@k-sareen
Copy link

I think it's probably related to #2895 as mentioned in my issue here: #3104 (comment).

@chocmake
Copy link
Author

chocmake commented Jun 1, 2022

I think it's probably related to #2895 as mentioned in my issue here: #3104 (comment).

I'd agree then with your suggestion to add an option to retain the previously set global settings rather than them being updated per video. Other settings don't behave in this new way for comparison (video quality, captions).

@chocmake
Copy link
Author

Just to add as an adjacent outcome of this, the playback speed for live videos is always auto set to 1x and with the current behavior any subsequent video(s) will also change to become 1x even if the video prior to viewing the livestream was set to some other speed.

@github-actions
Copy link

This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked.

@github-actions github-actions bot added stale and removed stale labels Jun 13, 2023
@SamantazFox SamantazFox added module:player Impacts the video player of Invidious module:account Preferences & account management labels Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module:account Preferences & account management module:player Impacts the video player of Invidious
Projects
None yet
Development

No branches or pull requests

3 participants