Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Remember Volume Level Settings Between Videos #3129

Open
Abystus opened this issue May 30, 2022 · 8 comments
Open

[Enhancement] Remember Volume Level Settings Between Videos #3129

Abystus opened this issue May 30, 2022 · 8 comments
Labels
enhancement Improvement of an existing feature

Comments

@Abystus
Copy link

Abystus commented May 30, 2022

Is your enhancement request related to a problem? Please describe.
Not a problem per say, but it is quite annoying for the player to not remember my last volume level used.

Describe the solution you'd like
A way to remember the last volume level used between videos. If I change it on one video, the next video should respect that change. This should override the global volume checkbox, and maybe should be a checkbox of its own to remember your settings between videos instead.

Describe alternatives you've considered
Manually adjusting the volume when moving between videos.

@Abystus Abystus added the enhancement Improvement of an existing feature label May 30, 2022
@unixfox
Copy link
Member

unixfox commented May 30, 2022

IMO global volume in the preferences is enough.

There is no really need to have a second way to set the global volume. That will confuse the users.

@Abystus
Copy link
Author

Abystus commented May 30, 2022

As an example, YouTube follows your last selected volume between videos.

This is also the same functionality used in Piped. The global volume is new to me, and seems unnecessary if the next video you watch respects the last volume setting you adjusted.

It gets old having to re adjust the volume between videos, especially when the volume of videos can vary internally (which also defeats the global static volume). I would like a feature that keeps track of my last setting, and be flexible by allowing me to change it on a whim (not digging in preferences) instead of relying on a static global volume.

My vote would be to have the global volume be changed into an internal non exposed variable, and be set by the user's last volume settings instead exposing it in preferences to prevent confusion.

@AHOHNMYC
Copy link
Contributor

AHOHNMYC commented May 30, 2022

@Abystus I think volume in Settings exists for users w/o enabled JS.
I upvote the idea. But how Invidious have to behave with multiple opened videos with different volumes?

@unixfox we may periodically synchronize volume on server with current volume. Maybe with another checkbox in Settings. (And I also agree with user confusing...)

@Abystus
Copy link
Author

Abystus commented May 30, 2022

@AHOHNMYC As for how the volume level in multiple tabs should work, it should stay the volume in each tab you have it set to, but if you change the volume in one tab, it wouldn't update any existing tabs you already have open (if you do this on YouTube you can see how this would work).

Only a newly loaded page would respect the last volume level touched, so if you changed the volume on any of those open tabs and then opened a new video, it would respect the last time the user adjusted the volume and follow what it was set to. The same applies to the mute functionality on YouTube where when you mute a video, the next video you open will also be muted (even if you close and reopen the browser).

Any questions in functionality would be answered by existing functionality in YouTube related to volume handling as I think they have the preferred method, and they are also the video site you are currently targeting users from.
I think it would be great addition as it is one of the things that bothers me when watching videos on Invidious as compared to on YouTube.

Maybe instead of a checkbox, it could be a dropdown on the global volume type (Dynamic or Static), and only when set on Static would the volume slider show in preferences?

@chocmake
Copy link

chocmake commented Jun 1, 2022

I'm confused. According to my own experience on two difference instances this is already the new behavior. Also someone pointed to #2895 which added this.

However there are drawbacks to this which I outlined in #3105. The prior approach of retaining the global volume provided a consistent, expected level regardless of the volume of the actual video. Youtube's approach of retaining the volume per video is something I always fought with for years and for a while used addons/userscripts to retain a fixed default volume because of it.

An example of why the prior Invidious behavior was useful is if one had to raise the volume to 100% for a person's low voice in one video (and potentially also raising one's speaker/headphone volume), then came back to Invidious at a later point not knowing what volume you'd set for the last video, it may be much too loud for the next played video—and if 'Autoplay' is disabled one can't visually check before playing either since it only displays the play button initially.

@Abystus
Copy link
Author

Abystus commented Jun 1, 2022

@chocmake I would think the method volume is handled could be configurable in preferences as I explained above. That way those who like the global volume to be something static and every so often tweaked could have that, and others that like it to remember per modification on a video could have it that way:

Volume Behavior Dropdown:

  1. Static (Volume level is set and remains unchanged until you alter it in preferences. Volume bar is visible in preferences.)
  2. Dynamic (Volume level changes each time the volume is modified on a video. Volume bar not visible or greyed out in preferences.)

I think this option would best address both sides of how volume is handled.

@hollunder
Copy link

Pretty much any web video player I know is simply storing the volume in a cookie on change and loading it from the cookie for the next video. I think those are the semantics people expect and it should be easy to implement.

@UltraBlackLinux
Copy link

IMO global volume in the preferences is enough.

This is way too annoying to access in my opinion. It should be as easy as setting that while playing a video. I often switch between using invidious for music (which shouldn't obscure anything else) and watching normal videos, and always having to go into the settings is quite a hassle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

6 participants