-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuration of the time between 2 RefreshChannelsJob #2915
Merged
SamantazFox
merged 9 commits into
iv-org:master
from
MathiusD:RefreshChannelsJob-frenquency
Feb 24, 2022
Merged
Allow configuration of the time between 2 RefreshChannelsJob #2915
SamantazFox
merged 9 commits into
iv-org:master
from
MathiusD:RefreshChannelsJob-frenquency
Feb 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiusD
requested review from
TheFrenchGhosty,
SamantazFox,
unixfox and
a team
as code owners
February 21, 2022 09:58
SamantazFox
requested changes
Feb 21, 2022
Follow indications : iv-org#2915 (comment)
Follow lint indications : iv-org#2915 (comment)
Follow indications : iv-org#2915 (comment)
Follow indications: iv-org#2915 (comment)
Follow lint indications : iv-org#2915 (comment)
Unrelated to the issue since the change in management of channel_refresh_interval Cf this remark : iv-org#2915 (comment)
SamantazFox
approved these changes
Feb 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is good. Some minor changes needed in the example config file.
Follow lint indications : - iv-org#2915 (comment) - iv-org#2915 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2060
The purpose of this PR is to allow the configuration of the time between 2 RefreshChannelsJob.
This PR proposes this configuration by adding the
channel_refresh_time
parameter in the configuration file (Cf usage inconfig/config.example.yml
)