-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix loading of TIF 16bits grayscale files #1107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the concise PR. I will review with the PR18 data and approve it when it passes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking all good. I think just need to update the source ivadomed/scripts/download_data.py
for the path to the release and ensuring to use the newer release:
"data_testing": {
"url": ["https://github.com/ivadomed/data-testing/archive/r20220221.zip"],
"description": "Data Used for integration/unit test in Ivadomed."},
Pull Request Test Coverage Report for Build 2054396579
💛 - Coveralls |
* segmentation_pair.py: Fix loading of gray TIF files * test_loader.py: Add test_read_png_tif * test_loader.py: Add keywords * Remove unnecessary length_2D and stride_2D in test_read_png_tif * Update data-testing link in download_data.py
Hi, I think I still have a problem with 16 bit tifs. Is there something wrong with my tif? I run exactly the same training/testing using the same set of 16 and 8bit images and predictions of the model are wrong for 16 bit images but reasonable for 8 bit images. I have fresh install of ivadomed Happy to share whole BIDS folder and imadomed output folder with the config file |
Just checked and I have the same problem with 16 bit PNG images. |
Checklist
GitHub
PR contents
Description
This PR fixes issue #1105 where TIF 16bits grayscale gave an error while loading:
Linked issues
Fixes #1105