Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Hint for sample_meta_data.py #1159

Merged
merged 3 commits into from
Nov 20, 2022
Merged

Type Hint for sample_meta_data.py #1159

merged 3 commits into from
Nov 20, 2022

Conversation

cakester
Copy link
Contributor

@cakester cakester commented Jun 8, 2022

Checklist

GitHub

  • I've given this PR a concise, self-descriptive, and meaningful title
  • I've linked relevant issues in the PR body
  • I've applied the relevant labels to this PR
  • I've assigned a reviewer

PR contents

Description

Type hint for sample_meta_data.py

Linked issues

@cakester cakester requested a review from dyt811 June 8, 2022 17:30
@coveralls
Copy link

coveralls commented Jun 8, 2022

Pull Request Test Coverage Report for Build 3508940825

  • 10 of 12 (83.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 69.036%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ivadomed/loader/sample_meta_data.py 10 12 83.33%
Totals Coverage Status
Change from base Build 3508915674: -0.007%
Covered Lines: 4254
Relevant Lines: 6162

💛 - Coveralls

@dyt811 dyt811 merged commit 8e08fc6 into master Nov 20, 2022
@dyt811 dyt811 deleted the typehint_sample_meta_data branch November 20, 2022 20:03
@mariehbourget mariehbourget added the refactoring PRs/Issues that solely deal with existing code reorganization label Jan 3, 2023
@mariehbourget mariehbourget added this to the new release milestone Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring PRs/Issues that solely deal with existing code reorganization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants