Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't declare pillow dependency #1187

Merged
merged 2 commits into from
Jul 31, 2022
Merged

Don't declare pillow dependency #1187

merged 2 commits into from
Jul 31, 2022

Conversation

kousu
Copy link
Contributor

@kousu kousu commented Jul 29, 2022

Checklist

GitHub

  • I've given this PR a concise, self-descriptive, and meaningful title
  • I've linked relevant issues in the PR body
  • I've applied the relevant labels to this PR
  • I've assigned a reviewer

PR contents

Description

Pillow (or PIL) is a dependency of imageio, not ivadomed: it's only used in one place in our code, and that, just a test.

By dropping it, we can let imageio choose the version it needs without raising the spectre of version conflicts.

Linked issues

Should help avoid the confusion raised in #1181 (comment)

Pillow (or PIL) is a dependency of imageio, not ivadomed: it's only used in one place in our code, and that, just a test.

By dropping it, we can let imageio choose the version it needs without raising the spectre of version conflicts.
@kousu kousu requested a review from dyt811 July 29, 2022 23:57
@coveralls
Copy link

coveralls commented Jul 30, 2022

Pull Request Test Coverage Report for Build 2769958734

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.148%

Totals Coverage Status
Change from base Build 2769957094: 0.0%
Covered Lines: 4236
Relevant Lines: 6126

💛 - Coveralls

Copy link
Member

@dyt811 dyt811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this.

@kousu kousu merged commit c0ca3fc into master Jul 31, 2022
@kousu kousu deleted the ng/drop-pillow branch July 31, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants