Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove force indexing of microscopy and update ct #1203

Merged
merged 14 commits into from
Nov 28, 2022

Conversation

mariehbourget
Copy link
Member

@mariehbourget mariehbourget commented Oct 26, 2022

Checklist

GitHub

  • I've given this PR a concise, self-descriptive, and meaningful title
  • I've linked relevant issues in the PR body
  • I've applied the relevant labels to this PR
  • I've assigned a reviewer

PR contents

Description

This PR aims to:

  • Remove the force indexing of microsocpy files no longer required since microscopy was integrated in the bids-validator v1.9.0 and in pybids v0.15.2.
  • Update the config_bids.json file to the latest version from pybids 0.15.5 with the addition of custom ct datatype.
  • Update the comments in the bids_dataframe.py file regarding ct-scan force indexing for clarity (related to Confusing variable name #1026).
  • Update CI tests and microscopy tutorial accordingly.

Notes:

Linked issues

Fixes #1026

@mariehbourget mariehbourget added the refactoring PRs/Issues that solely deal with existing code reorganization label Oct 26, 2022
@coveralls
Copy link

coveralls commented Oct 26, 2022

Pull Request Test Coverage Report for Build 3515689391

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 69.146%

Totals Coverage Status
Change from base Build 3515543572: 0.2%
Covered Lines: 4305
Relevant Lines: 6226

💛 - Coveralls

@@ -99,7 +103,7 @@
},
{
"name": "datatype",
"pattern": "[/\\\\]+(anat|beh|dwi|eeg|fmap|func|ieeg|meg|perf|micr|ct)[/\\\\]+"
"pattern": "[/\\\\]+(anat|beh|dwi|eeg|fmap|func|ieeg|meg|micr|perf|pet|ct)[/\\\\]+"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to the reviewer:
This file was use as a "custom" pybids config to index microscopy & ct-scan files while they were not BIDS compliant. It is a copy of the pybids config file with the addition of "custom" field needed for micr & ct.

With this PR, we won't need the "custom" pybids config anymore for micr, but will still need it for ct.
As such, the only difference between this custom file and the official pybids config from here is the addition of ct on this line.

@mariehbourget mariehbourget marked this pull request as ready for review November 16, 2022 15:47
Copy link
Member

@jcohenadad jcohenadad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i only gave it a quick glance, thank you @mariehbourget !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring PRs/Issues that solely deal with existing code reorganization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing variable name
3 participants