-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove force indexing of microscopy and update ct #1203
Conversation
Pull Request Test Coverage Report for Build 3515689391Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
@@ -99,7 +103,7 @@ | |||
}, | |||
{ | |||
"name": "datatype", | |||
"pattern": "[/\\\\]+(anat|beh|dwi|eeg|fmap|func|ieeg|meg|perf|micr|ct)[/\\\\]+" | |||
"pattern": "[/\\\\]+(anat|beh|dwi|eeg|fmap|func|ieeg|meg|micr|perf|pet|ct)[/\\\\]+" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to the reviewer:
This file was use as a "custom" pybids config to index microscopy & ct-scan files while they were not BIDS compliant. It is a copy of the pybids config file with the addition of "custom" field needed for micr
& ct
.
With this PR, we won't need the "custom" pybids config anymore for micr
, but will still need it for ct
.
As such, the only difference between this custom file and the official pybids config from here is the addition of ct
on this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i only gave it a quick glance, thank you @mariehbourget !
Checklist
GitHub
PR contents
Description
This PR aims to:
config_bids.json
file to the latest version from pybids 0.15.5 with the addition of customct
datatype.Notes:
The PR is still a draft since we have issues/investigations in-progress that I would like to check in parallel before merging (BIDS derived datasets file naming #860, Update our definition of labels to comply with BIDS #1202 and ADS #605).EDIT: After verification, these issues are not in conflict with the implementation from this PR.Linked issues
Fixes #1026