-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove force indexing of microscopy and update ct #1203
Merged
Merged
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
94ffa31
bids_dataframe.py: Remove force indexing of micr files
mariehbourget b7b0561
Rename variable ext_ct to extension_ct for clarity
mariehbourget c9b17ff
Update comments to clarify CT force indexing and BIDS layout init
mariehbourget fe83801
Add missing variable subject_path
mariehbourget bf55f14
config/bids_config.json: Update to bids.json config of pybids 0.15.4
mariehbourget df531bc
config/bids_config.json: Add custom "ct" datatype
mariehbourget ba4b0a8
Update tutorials/two_class_microscopy_seg_2d_unet.rst
mariehbourget 82916a3
Update test_loader.py
mariehbourget 1ba482f
Update test_patch_filter.py and test_testing.py
mariehbourget 225eaba
bids_dataframe.py: Update comments to clarify use of custom bids_config
mariehbourget 31df618
bids_dataframe.py: update comments on pybids for tsv metadata
mariehbourget b3c7a8c
Fix config_bids.json "name" field
mariehbourget d134642
Merge branch 'master' into mhb/update-force-index-micr-ct
mariehbourget 2e5f54b
Merge branch 'master' into mhb/update-force-index-micr-ct
mariehbourget File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to the reviewer:
This file was use as a "custom" pybids config to index microscopy & ct-scan files while they were not BIDS compliant. It is a copy of the pybids config file with the addition of "custom" field needed for
micr
&ct
.With this PR, we won't need the "custom" pybids config anymore for
micr
, but will still need it forct
.As such, the only difference between this custom file and the official pybids config from here is the addition of
ct
on this line.