re apache#3724: tablet transaction log

* Use enum in descriptions
ivakegg · Aug 27, 2023 · 312ced3 · 312ced3
1 parent 6f23198
commit 312ced3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/core/src/main/java/org/apache/accumulo/core/conf/Property.java b/core/src/main/java/org/apache/accumulo/core/conf/Property.java
@@ -1196,13 +1196,16 @@ public enum Property {
       "The maximum number of logged operations logged in memory for diagnostic purposes. "
           + "The log will can be used for diagnosing if and when in-memory file list diverges from metadata.",
       "2.1.3"),
-  TABLE_OPERATION_LOG_RECOVERY("table.operation.log.recovery.action", "log",
+  TABLE_OPERATION_LOG_RECOVERY("table.operation.log.recovery.action", LogSync.log.name(),
       PropertyType.DATAFILE_RECOVERY_ACTION,
       "The action to take when the in-memory file list is found to be different than the metadata. "
-          + "1) log: simply log the operation log, "
-          + "2) logsync: sync in-memory and metadata with the log, "
-          + "3) metasync: sync memory with what the metadata holds, "
-          + "4) memsyn: sync metadata with what in-memory holds.",
+          + "1) " + LogSync.log.name() + ": simply log the operation log, " + "2) "
+          + LogSync.logsync.name()
+          + ": sync in-memory and metadata with the log depending on what the operation log agrees with, "
+          + "3) " + LogSync.metasync.name()
+          + ": update memory with what the metadata holds if operation log agrees with metadata, "
+          + "4) " + LogSync.memsync.name()
+          + ": update metadata with what in-memory holds if operation log agrees with memory.",
       "2.1.3"),
   TABLE_ITERATOR_PREFIX("table.iterator.", null, PropertyType.PREFIX,
       "Properties in this category specify iterators that are applied at"

diff --git a/core/src/main/java/org/apache/accumulo/core/conf/PropertyType.java b/core/src/main/java/org/apache/accumulo/core/conf/PropertyType.java
@@ -132,8 +132,8 @@ public enum PropertyType {
   DATAFILE_RECOVERY_ACTION("datafile_recovery_action",
       in(true, null, LogSync.log.name(), LogSync.logsync.name(), LogSync.metasync.name(),
           LogSync.memsync.name()),
-      "One of '" + LogSync.log + "', '" + LogSync.logsync + "', '" + LogSync.metasync + "', '"
-          + LogSync.memsync + "'"),
+      "One of '" + LogSync.log.name() + "', '" + LogSync.logsync.name() + "', '"
+          + LogSync.metasync.name() + "', '" + LogSync.memsync.name() + "'"),
   LAST_LOCATION_MODE("last_location_mode", in(true, null, "assignment", "compaction"),
       "Defines how to update the last location.  One of 'assignment', or 'compaction'."),