Code review changes - Minimize changes for apache/accumulo#3400 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctubbsii
commented
May 13, 2023
ctubbsii
commented
- Improve javadoc comments on environment interface
- Remove unneeded AccumuloConfigurationAdaptor - instead, keep the DefaultContextClassLoaderFactory constructed directly using the internal configuration, rather than load it through reflection using the no-arg constructor. We don't want users configuring this class manually, so it should not have a no-arg constructor. As the javadoc states, it is for internal use only.
- Use a lambda for passing the service configuration rather than an anonymous inner class (less code, same effect)
* Improve javadoc comments on environment interface * Remove unneeded AccumuloConfigurationAdaptor - instead, keep the DefaultContextClassLoaderFactory constructed directly using the internal configuration, rather than load it through reflection using the no-arg constructor. We don't want users configuring this class manually, so it should not have a no-arg constructor. As the javadoc states, it is for internal use only. * Use a lambda for passing the service configuration rather than an anonymous inner class (less code, same effect)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.