core: warn when model is added to a different collection.

This can lead to inconsistencies in model data (if both collections try to persist the model)
ivandotv · Oct 22, 2021 · 082abd6 · 082abd6
1 parent 66d03e1
commit 082abd6
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/.changeset/polite-schools-explode.md b/.changeset/polite-schools-explode.md
@@ -0,0 +1,5 @@
+---
+'@fuerte/core': patch
+---
+
+core: Warn when model is added to a different collection.
diff --git a/packages/core/src/model/Model.ts b/packages/core/src/model/Model.ts
@@ -163,6 +163,15 @@ export abstract class Model<
 
   // @internal
   _onAdded(collection: TCollection): void {
+    if (__DEV__) {
+      if (this.collection) {
+        console.warn(
+          `Model=> onAdded: model is already in a different collection. This can lead to inconsistencies in model state.
+           Old collection: ${this.collection.constructor}
+           New collection: ${collection.constructor}`
+        )
+      }
+    }
     this.collection = collection
     this.onAdded()
   }