refactor autosave types

ivandotv · Jul 1, 2022 · ebee7da · ebee7da
1 parent 35cc2b8
commit ebee7da
Show file tree

Hide file tree

Showing 4 changed files with 314 additions and 39 deletions.
diff --git a/.changeset/blue-toys-explode.md b/.changeset/blue-toys-explode.md
@@ -0,0 +1,6 @@
+---
+'@fuerte/core': major
+---
+
+refactor exported Typescript types
+refactor `AutosaveCollectionConfig`
diff --git a/packages/core/src/collection/AutosaveCollection.ts b/packages/core/src/collection/AutosaveCollection.ts
@@ -30,7 +30,7 @@ export class AutosaveCollection<
     this.config.autoSave = {
       enabled: false,
       debounce: 0,
-      ...(config?.autoSave ? config.autoSave : undefined)
+      ...(config?.autoSave || undefined)
     }
   }
 

diff --git a/packages/core/src/collection/Collection.ts b/packages/core/src/collection/Collection.ts
@@ -41,15 +41,23 @@ import {
 } from '../types'
 import { ASYNC_STATUS, isPromise, wrapInArray } from '../utils'
 
+/** Dupicate model strategies*/
 export const DuplicateModelStrategy = {
+  /** keep the new model*/
   KEEP_NEW: 'KEEP_NEW',
+  /** keep the old model*/
   KEEP_OLD: 'KEEP_OLD',
+  /** use compare function*/
   COMPARE: 'COMPARE'
 } as const
 
+/** Model compare results*/
 export const ModelCompareResult = {
+  /** keep the new model*/
   KEEP_NEW: 'KEEP_NEW',
+  /** keep the old model*/
   KEEP_OLD: 'KEEP_OLD',
+  /** keep both models. Make sure they have different identities*/
   KEEP_BOTH: 'KEEP_BOTH'
 } as const