Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "glob" file name matching #42

Merged
merged 3 commits into from
Dec 14, 2022
Merged

feat: add "glob" file name matching #42

merged 3 commits into from
Dec 14, 2022

Conversation

ivanilves
Copy link
Owner

@ivanilves ivanilves commented Dec 12, 2022

  • add normalizeNameEx() func to select files by glob;
  • remove useless PathEx variable because YAGNI;

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #42 (1dfdac2) into main (6007859) will increase coverage by 10.90%.
The diff coverage is 87.80%.

@@             Coverage Diff             @@
##             main      #42       +/-   ##
===========================================
+ Coverage   85.60%   96.50%   +10.90%     
===========================================
  Files          12       11        -1     
  Lines         250      229       -21     
===========================================
+ Hits          214      221        +7     
+ Misses         36        8       -28     
Impacted Files Coverage Δ
pkg/config/mode/common.go 100.00% <ø> (ø)
pkg/config/mode/dockerfile.go 100.00% <ø> (ø)
pkg/config/mode/groovy.go 100.00% <ø> (ø)
pkg/config/mode/jenkinsfile.go 100.00% <ø> (ø)
pkg/config/mode/terraform.go 100.00% <ø> (ø)
pkg/config/mode/terragrunt.go 100.00% <ø> (ø)
pkg/config/config.go 81.25% <40.00%> (ø)
pkg/config/mode_fn.go 90.00% <90.00%> (ø)
pkg/directory/directory.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ivanilves ivanilves changed the title feat: add normalizeNameEx func to select files by glob feat: add "glob" file name matching Dec 14, 2022
Comment on lines -17 to -18
// PathEx is a regex to be matched against the passed file full path
PathEx string `yaml:"path"`
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAGNI 😐

@ivanilves ivanilves merged commit 9e613e1 into main Dec 14, 2022
@ivanilves ivanilves deleted the normalize-glob branch December 14, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant