Add support for NeoComplete #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CompleteIPython if it is the current omnifunc
(but wrap in try in case it's not connected)
Currently stdin_channel is ignored which means the kernel freezes waiting for a stdin reply if input() is called. Pass allow_stdin=False to give an immediate exception instead of hanging.
This prevents having to check if the metadata dict contains the 'info' or 'menu' keys and allows other keys e.g. 'abbr' to be used automatically if they are specified in the completion_metadata function.
Don't cause an exception in the user's IPython if they haven't defined the completion_metadata function.
Accidentally didn't put back 'word' into the result. This is a big problem if the user's completion_metadata doesn't manually add 'word' to the dict. Oops. Intentionally wrote it so the user may override 'word' in the metadata dict if desired (e.g. to add an opening parenthesis to a function call).
Make doc buffer `nomodifiable`. The line below the line you changed has `nomodifiable` in it and is commented out but I looked through the commit history and it was like that in the initial version so who knows why it's commented out. Seems like a good idea.
…of the vim-ipython buffer
…er. Use :IPythonInput instead
accept stdin requests and add method to reply to them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a source definition file for using your IPython completion with NeoComplete as well as an option to set omnifunc instead of completefunc (NeoComplete uses completefunc but incorporates another omnifunc).