Validate Null Requests #37

ivanpaulovich · Oct 21, 2019 · b3d03b1 · b3d03b1
1 parent b5ac398
commit b3d03b1
Show file tree

Hide file tree

Showing 7 changed files with 63 additions and 3 deletions.
diff --git a/changelog.md b/changelog.md
@@ -1,5 +1,9 @@
 # Change Log
 
+## 2019-10-20 - 0.4.4
+
+* #37 Validation for Null Requests added.
+
 ## 2019-10-20 - 0.4.3
 
 * #2 Support o Named Pipelines Added.

diff --git a/...nsions.DependencyInjection/FluentMediator.Microsoft.Extensions.DependencyInjection.csproj b/...nsions.DependencyInjection/FluentMediator.Microsoft.Extensions.DependencyInjection.csproj
@@ -6,7 +6,7 @@
 
   <PropertyGroup>
     <PackageId>FluentMediator.Microsoft.Extensions.DependencyInjection</PackageId>
-    <Version>0.4.3</Version>
+    <Version>0.4.4</Version>
     <Authors>Ivan Paulovich</Authors>
     <Copyright>Ivan Paulovich</Copyright>
     <Description>Microsoft Extensions for FluentMediator.</Description>

diff --git a/src/FluentMediator/FluentMediator.csproj b/src/FluentMediator/FluentMediator.csproj
@@ -10,7 +10,7 @@
 
 	<PropertyGroup>
     <PackageId>FluentMediator</PackageId>
-    <Version>0.4.3</Version>
+    <Version>0.4.4</Version>
     <Authors>Ivan Paulovich</Authors>
     <Copyright>Ivan Paulovich</Copyright>
     <Description>FluentMediator is an unobtrusive library that allows developers to build custom pipelines for Commands, Queries and Events.</Description>

diff --git a/src/FluentMediator/Mediator.cs b/src/FluentMediator/Mediator.cs
@@ -18,6 +18,11 @@ public sealed class Mediator : IMediator
 
         public void Publish(object request, string? pipelineName = null)
         {
+            if (request is null)
+            {
+                throw new NullRequestException("The request is null.");
+            }
+
             if (pipelineName is string)
             {
                 var pipeline = _pipelines.GetPipeline(pipelineName);
@@ -33,6 +38,11 @@ public void Publish(object request, string? pipelineName = null)
 
         public TResult Send<TResult>(object request, string? pipelineName = null)
         {
+            if (request is null)
+            {
+                throw new NullRequestException("The request is null.");
+            }
+
             if (pipelineName is string)
             {
                 var pipeline = _pipelines.GetPipeline(pipelineName);
@@ -47,6 +57,11 @@ public TResult Send<TResult>(object request, string? pipelineName = null)
 
         public async Task PublishAsync(object request, string? pipelineName = null)
         {
+            if (request is null)
+            {
+                throw new NullRequestException("The request is null.");
+            }
+
             if (pipelineName is string)
             {
                 var pipeline = _pipelines.GetAsyncPipeline(pipelineName);
@@ -61,6 +76,11 @@ public async Task PublishAsync(object request, string? pipelineName = null)
 
         public async Task<TResult> SendAsync<TResult>(object request, string? pipelineName = null)
         {
+            if (request is null)
+            {
+                throw new NullRequestException("The request is null.");
+            }
+
             if (pipelineName is string)
             {
                 var pipeline = _pipelines.GetAsyncPipeline(pipelineName);
@@ -75,6 +95,11 @@ public async Task<TResult> SendAsync<TResult>(object request, string? pipelineNa
 
         public async Task PublishAsync(object request, CancellationToken ct, string? pipelineName = null)
         {
+            if (request is null)
+            {
+                throw new NullRequestException("The request is null.");
+            }
+
             if (pipelineName is string)
             {
                 var pipeline = _pipelines.GetCancellablePipeline(pipelineName);
@@ -89,6 +114,11 @@ public async Task PublishAsync(object request, CancellationToken ct, string? pip
 
         public async Task<TResult> SendAsync<TResult>(object request, CancellationToken ct, string? pipelineName = null)
         {
+            if (request is null)
+            {
+                throw new NullRequestException("The request is null.");
+            }
+
             if (pipelineName is string)
             {
                 var pipeline = _pipelines.GetCancellablePipeline(pipelineName);

diff --git a/src/FluentMediator/NullRequestException.cs b/src/FluentMediator/NullRequestException.cs
@@ -0,0 +1,9 @@
+namespace FluentMediator
+{
+    public class NullRequestException: MediatorException
+    {
+        public NullRequestException() { }
+        public NullRequestException(string message) : base(message) { }
+        public NullRequestException(string message, System.Exception inner) : base(message, inner) { }
+    }
+}
diff --git a/test/UnitTests/SendingRequestTests.cs b/test/UnitTests/SendingRequestTests.cs
@@ -245,5 +245,22 @@ public void Send_Not_Configured_Throws_PipelineNotFoundException()
             Assert.NotNull(actualEx);
             Assert.IsType<PipelineNotFoundException>(actualEx);
         }
+
+        [Fact]
+        public void Send_Throws_Exception_Null_Requests()
+        {
+            var services = new ServiceCollection();
+            services.AddFluentMediator(m =>
+            { });
+
+            services.AddScoped<IPingHandler, PingHandler>();
+            var provider = services.BuildServiceProvider();
+            var mediator = provider.GetRequiredService<IMediator>();
+
+            var actualEx = Record.Exception(() => mediator.Send<PingResponse>(null!));
+
+            Assert.NotNull(actualEx);
+            Assert.IsType<NullRequestException>(actualEx);
+        }
     }
 }
diff --git a/test/UnitTests/UnitTests.csproj b/test/UnitTests/UnitTests.csproj
@@ -15,7 +15,7 @@
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.1" />
     <DotNetCliToolReference Include="dotnet-xunit" Version="2.3.1" />
     <PackageReference Include="Microsoft.AspNetCore.App" />
-    <PackageReference Include="Moq" Version="4.13.0"/>
+    <PackageReference Include="Moq" Version="4.13.1"/>
   </ItemGroup>
 
   <ItemGroup>