Do not overwrite the updateModel method of a FormComponent

[coder-hugo]

• if you use wicket the right way there is no need the overwrite the updateModel method for a custom form component
• this strange code inside the updateModel method caused an error in combination with the wicket-bootstrap library
  -> the FormGroup component implements the interface IFormModelUpdateListener (which is also wrong) and cause that the updateModel method of each FormComponent gets called twice
  -> calling this updateModel method twice within one request cycle results in an empty collection for the model object

[ivaynberg]

if you use wicket the right way there is no need the overwrite the updateModel method for a custom form component

this is incorrect. form components that work with collections typically override updateModel to handle the collection appropriately. if this method is removed entirely a brand new collection will always gets pushed to the component, with this method in place an existing collection if present will be modified - which is most often the desired behavior.

this strange code inside the updateModel method caused an error in combination with the wicket-bootstrap library

perhaps the bug is in the bootstrap module.

however, i did notice that the existing code does not notify the component that its model is changing, which may also cause a problem.

this is now fixed.

[coder-hugo]

Thanks,

till now I always thought that it's the expected behavior that also for collections you get a new instance for the model object after a form submit. But this is indeed the better solution ;-)
And with this code:

    @Override
    public void updateModel() {
        FormComponent.updateCollectionModel(this);
    }

it works also in combination with the other bug that calls the updateModel method twice for each form compoent.