Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saved search queries #1

Open
flamby opened this issue Apr 7, 2017 · 6 comments
Open

Saved search queries #1

flamby opened this issue Apr 7, 2017 · 6 comments

Comments

@flamby
Copy link

flamby commented Apr 7, 2017

Hi,

First of all, kudos, this app fills a gap in django admin UX.

It would be nice to have a save query button, and a select menu in the search bar to re-use them.

Keep the good work!

@stebunovd stebunovd changed the title Feature request Saved search queries Apr 7, 2017
@stebunovd
Copy link
Member

Hi!

thanks, I'm glad you liked it.

as for Save query button - that might be interesting, I even briefly thought about this. Any ideas what UI part may look like? I suppose it should be pluggable into any admin configurations, both with and without list_filter, and play nicely with it.

@flamby
Copy link
Author

flamby commented Apr 7, 2017

there is this tool I'm using which use this UI pattern for that idea :
https://www.dropbox.com/s/35wejrng3z6u3yv/Capture%20d%27%C3%A9cran%202017-04-07%2014.14.50.png?dl=0

but i guess you'll have to rewrite the widget, maybe not that easy.

@stebunovd
Copy link
Member

thanks - just a quick question to make sure that I correctly understand your idea - ⭐️ icon should be placed in the input field on the right, and it should bring a popup with saved queries - correct?

If yes, where would you recommend to place it when the input is growing? Maybe this feature is not obviously visible to users, so I'll explain a little bit. DjangoQL input is not just a regular input, it's a textarea that adjusts its height automatically when users enter a lot of text. That was done to have search query always visible without scrolling, even if its really long. I've tested it on real use cases that we have in our company, and 1 line doesn't seem to be enough for all cases, that's why auto-resize feature was added. So - taken the fact that the search input could adjust its height, where would you suggest to place a ⭐️ icon? Top? Bottom? Middle? Outside of input?

Another side of the problem that I think about - which functionality do we want to support for search queries? Off the top of my head:

  1. Save current query;
  2. Discover list of saved queries and pick a query from that list;
  3. If current query is a saved query, have a clear indication of which saved query is currently applied;
  4. If saved query has been selected and after that search query was modified manually... Well, this should probably somehow affect indication of currently applied query;
  5. Rename and delete saved queries;
  6. Two modes of saved queries: Personal (for current user only) and Shared (for all users)

Am I missing something?

@flamby
Copy link
Author

flamby commented Apr 7, 2017

Perhaps a more simpler approach would be to have the star icon separated from the input field, placed as a select button w/ dropdown for list of saved queries and a search engine at the top based on query label (if you want to add one) and the query itself, and on all queries of the list, a delete button on the right, that's simple. the dropdown could be scrollable to keep a short height, and the search engine would keep it very convenient.

It would address 1/ 2/ 5/
renaming is just a matter of selecting previous query, deleting it, and adding the modified one.

6/ is probably more complex

@stebunovd
Copy link
Member

I think replacing "rename" with add/delete could work, this is probably not a frequent action.

What about 3/ and 6/? I suppose that shared search queries could be useful for less experienced users, so ability to share a query and a clear indication of current applied query should be important..

@flamby
Copy link
Author

flamby commented Apr 7, 2017

yes, 3/ and 6/ are great too.

Frenk1 added a commit to Frenk1/djangoql that referenced this issue Apr 14, 2017
Frenk1 added a commit to Frenk1/djangoql that referenced this issue Apr 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants