Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2+ Go modules #82

Closed
2 tasks done
applejag opened this issue Jan 12, 2022 · 0 comments
Closed
2 tasks done

v2+ Go modules #82

applejag opened this issue Jan 12, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request
Projects

Comments

@applejag
Copy link
Contributor

applejag commented Jan 12, 2022

Based on RFC: iver-wharf/rfcs#26
Published: https://iver-wharf.github.io/rfcs/published/0026-v2-go-modules-release

Need to update the module names in the following repos to include the major version as suffix:

Motivation

We need to stay compatible with Go modules to be able to use this library from other projects. Go modules almost requires it's own doctrine, but this PR is based on some statements from here: https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher

Example errors that appear as we haven't been Go modules compatibility up until now:

$ go get github.com/iver-wharf/wharf-api/pkg/orderby@v4.2.0
go get github.com/iver-wharf/wharf-api/pkg/orderby@v4.2.0:
  github.com/iver-wharf/wharf-api@v4.2.0:
    invalid version:
      module contains a go.mod file, so major version must be compatible:
        should be v0 or v1, not v4

(I've wrapped the text in console output just to be more easily readable)

@applejag applejag added the enhancement New feature or request label Jan 12, 2022
@applejag applejag self-assigned this Jan 12, 2022
@applejag applejag added this to To do in Backlog via automation Jan 12, 2022
Backlog automation moved this from To do to Done Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

1 participant